Run C++ unit tests on AppVeyor #2875
Conversation
glebm
force-pushed
the
appveyor-unit-tests
branch
from
b7b4a5f to
c173450
Compare
glebm
changed the title
|
@glebm big thanks for all your work. I've given you commit access to unblock you. |
|
@xzyfer Thanks! |
glebm
force-pushed
the
appveyor-unit-tests
branch
from
c173450 to
86267ec
Compare
Previously, these only ran on Travis.
glebm
force-pushed
the
appveyor-unit-tests
branch
from
86267ec to
1612937
Compare
glebm
changed the title
|
@mgreter I don't have any msbuild / Windows experience. I've hand-coded these |
|
@xzyfer I don't seem have commit access! No big deal though, as I'd like all my PRs reviewed anyway, but it'd be nice to be able to set labels on issues etc. |
|
Sorry I misclicked on mobile. You should have write access now. Your changes are sensible so I'd prefer not to block your windows of productivity. Please to request reviews when you think it makes sense. I personally follow changes via Github emails so I'll pop up if I have string feelings about something. Additionally this should give you the power to kill AppVeyor and Travis CI builds which can been a huge time saver. |
|
I know nothing about vs studio but agree with the intent of the change :) |
| @@ -0,0 +1,8 @@ | |||
| <Project DefaultTargets="Build" ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
There was a problem hiding this comment.
I think "ToolsVersion" is lower because we're still stuck on 2013. ? Maybe 12.0
There was a problem hiding this comment.
I took it from here but I think you're right: https://github.com/sass/libsass/blob/9740de67d01d1f9da0278dca1ffad984304f9124/win/libsass.vcxproj#2
This MSDN article says:
Visual Studio 2013 uses a ToolsVersion of 12.0. Visual Studio 2015 uses ToolsVersion 14.0
3 participants
Previously, these only ran on Travis.